dataclasses: 3.12.3 regression with weakref_slot

[francis-clairicia]

Bug report

Bug description:

The __weakref__ slot is not set for classes that have a Generic[T] base.

from typing import Generic, TypeVar
from dataclasses import dataclass

T = TypeVar("T")

@dataclass(slots=True, weakref_slot=True)
class Token(Generic[T]):
    ctx: T

print(f"{Token.__slots__=!r}")
print(f"{hasattr(Token, '__weakref__')=}")

Output on 3.12.2:

Token.__slots__=('ctx', '__weakref__')
hasattr(Token, '__weakref__')=True

On 3.12.3:

Token.__slots__=('ctx',)
hasattr(Token, '__weakref__')=False

CPython versions tested on:

3.12

Operating systems tested on:

Linux, macOS, Windows

Linked PRs

• gh-118033: Fix __weakref__ not set for generic dataclasses #118099
• [3.13] gh-118033: Fix __weakref__ not set for generic dataclasses (GH-118099) #118821
• [3.12] gh-118033: Fix __weakref__ not set for generic dataclasses (GH-118099) #118822

[Eclips4]

Bisected to a22d05f.

[sobolevn]

Looks like that we need to check __weakref__offset__, then we can decide whether this type has __weakref__ slot or not.

[sobolevn]

Let's close this issue. I opened a new one for @carljm's suggestion about __slots__ on C types. See #118099 (comment)

[sobolevn]

#118829