Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TracebackException.exc_type #112332

Closed
iritkatriel opened this issue Nov 23, 2023 · 0 comments · Fixed by #112333
Closed

Deprecate TracebackException.exc_type #112332

iritkatriel opened this issue Nov 23, 2023 · 0 comments · Fixed by #112333
Assignees
@iritkatriel

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Nov 23, 2023 •
edited by bedevere-app bot
Loading

TracebackException is supposed to be a printable snapshot of an exception. It is intended to be lightweight (release references to frames, etc) and easily serialised.

Since the exc_type field is causing issues for subinterpreters, I suggest we deprecate it and replace it with a snapshot of the type.

Until removed, we can have an arg to optionally not save it (which can be used by subinterpreters).

Linked PRs
@iritkatriel iritkatriel self-assigned this Nov 23, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Nov 23, 2023
@iritkatriel
pythongh-112332: save snapshot of exc_type in TracebackException. Add…
aad7828 
… option to not save the exc_type itself.
@iritkatriel iritkatriel mentioned this issue Nov 23, 2023
Merged
@ericsnowcurrently ericsnowcurrently mentioned this issue Nov 28, 2023
Closed
iritkatriel added a commit that referenced this issue Nov 28, 2023
@iritkatriel
gh-112332: Deprecate TracebackException.exc_type, add exc_type_str. (#…
2c68011 
…112333)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@iritkatriel @aisk
pythongh-112332: Deprecate TracebackException.exc_type, add exc_type_…
4289b72 
…str. (python#112333)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112332: Deprecate TracebackException.exc_type, add exc_type_…
98425f8 
…str. (python#112333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-112332: Deprecate TracebackException.exc_type, add exc_type_str. iritkatriel/cpython
1 participant
@iritkatriel