Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for complexobject.c #109802

Closed
skirpichev opened this issue Sep 24, 2023 · 0 comments
Closed

More tests for complexobject.c #109802

skirpichev opened this issue Sep 24, 2023 · 0 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@skirpichev
Copy link
Member

skirpichev commented Sep 24, 2023 •
edited by bedevere-app bot
Loading

Right now ./python -m test test_complex test_cmath only partially cover implementation of the complex object. Some code/branches are just inaccessible (e.g. L135-136 or mask <= 0 on L166; line numbers are wrt to 54fbfa8). There are only indirect tests for C-API functions (e.g. PyComplex_RealAsDouble, PyComplex_ImagAsDouble).

Linked PRs
@skirpichev skirpichev added the type-feature A feature request or enhancement label Sep 24, 2023
skirpichev added a commit to skirpichev/cpython that referenced this issue Sep 24, 2023
@skirpichev
pythongh-109802: Increase test coverage for complexobject.c
facb60b 
* _Py_c_pow: L134 (this case goes to c_powi() due to L523), L139

// line numbers wrt to 54fbfa8
@bedevere-app bedevere-app bot mentioned this issue Sep 24, 2023
Closed
@AlexWaygood AlexWaygood added the tests Tests in the Lib/test dir label Sep 24, 2023
@bedevere-app bedevere-app bot mentioned this issue Nov 27, 2023
Merged
serhiy-storchaka pushed a commit that referenced this issue Nov 28, 2023
@skirpichev
gh-109802: Increase test coverage for complexobject.c (GH-112452)
f14d741
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 28, 2023
@skirpichev @miss-islington
pythongh-109802: Increase test coverage for complexobject.c (pythonGH…
bea878a 
…-112452)

(cherry picked from commit f14d741)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 28, 2023
Merged
serhiy-storchaka pushed a commit that referenced this issue Nov 28, 2023
@miss-islington @skirpichev
[3.12] gh-109802: Increase test coverage for complexobject.c (GH-112452…
e28722e 
…) (GH-112489)

(cherry picked from commit f14d741)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@skirpichev @aisk
pythongh-109802: Increase test coverage for complexobject.c (pythonGH…
a1d99d6 
…-112452)
skirpichev added a commit to skirpichev/cpython that referenced this issue Apr 2, 2024
@skirpichev
pythongh-109802: Add coverage test for complex_abs()
6370883 
This tests overflow on L594.

// line numbers wrt to 0f2fa61
@bedevere-app bedevere-app bot mentioned this issue Apr 2, 2024
Merged
encukou pushed a commit that referenced this issue Apr 4, 2024
@skirpichev
gh-109802: Add coverage test for complex_abs() (GH-117449)
63bbe77 
* gh-109802: Add coverage test for complex_abs()

This tests overflow on L594.

// line numbers wrt to 0f2fa61
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@skirpichev @diegorusso
pythongh-109802: Add coverage test for complex_abs() (pythonGH-117449)
5c8f4e5 
* pythongh-109802: Add coverage test for complex_abs()

This tests overflow on L594.

// line numbers wrt to 0f2fa61
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@skirpichev @Glyphack
pythongh-109802: Increase test coverage for complexobject.c (pythonGH…
6eb0115 
…-112452)
@skirpichev skirpichev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skirpichev @AlexWaygood and others