-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libregrtest: Improve type hints; explore running mypy in CI #109413
Labels
Comments
AlexWaygood
added
type-feature
A feature request or enhancement
tests
Tests in the Lib/test dir
labels
Sep 14, 2023
We currently do not have any projects inside the |
AlexWaygood
added a commit
that referenced
this issue
Sep 14, 2023
AlexWaygood
changed the title
libregrtest: Improve type hints; explore running mypy on CI
libregrtest: Improve type hints; explore running mypy in CI
Sep 14, 2023
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this issue
Sep 15, 2023
AlexWaygood
added a commit
that referenced
this issue
Sep 15, 2023
This was referenced Sep 15, 2023
hauntsaninja
pushed a commit
that referenced
this issue
Sep 18, 2023
Improve the mypy config file for libregrtest
csm10495
pushed a commit
to csm10495/cpython
that referenced
this issue
Sep 28, 2023
Improve the mypy config file for libregrtest
AlexWaygood
added a commit
that referenced
this issue
Nov 30, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this issue
Dec 1, 2023
… on most files
vstinner
added a commit
to vstinner/cpython
that referenced
this issue
Dec 1, 2023
AlexWaygood
pushed a commit
that referenced
this issue
Dec 1, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Dec 1, 2023
(cherry picked from commit f8ff80f) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Dec 1, 2023
(cherry picked from commit f8ff80f) Co-authored-by: Victor Stinner <vstinner@python.org>
This was referenced Dec 1, 2023
AlexWaygood
pushed a commit
that referenced
this issue
Dec 1, 2023
AlexWaygood
pushed a commit
that referenced
this issue
Dec 1, 2023
AlexWaygood
added a commit
that referenced
this issue
Dec 1, 2023
…st files (#112586) Co-authored-by: Victor Stinner <vstinner@python.org>
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this issue
Dec 1, 2023
… on most files (python#112586) Co-authored-by: Victor Stinner <vstinner@python.org>
sobolevn
added a commit
that referenced
this issue
Nov 14, 2024
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Nov 15, 2024
sobolevn
added a commit
that referenced
this issue
Nov 18, 2024
…rs` (#126855) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Nov 18, 2024
…_workers` (pythonGH-126855) (cherry picked from commit a1d9c8a) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Nov 19, 2024
…ode` from `libregrtest/mypy.ini`
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Nov 19, 2024
…ode` from `libregrtest/mypy.ini`
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Nov 19, 2024
…ode` from `libregrtest/mypy.ini`
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Nov 19, 2024
…hecking `libregrtest` (pythonGH-127033) (cherry picked from commit 824afbf) Co-authored-by: sobolevn <mail@sobolevn.me>
vstinner
added a commit
to vstinner/cpython
that referenced
this issue
Nov 22, 2024
Skip threads which are not running.
vstinner
added a commit
to vstinner/cpython
that referenced
this issue
Nov 22, 2024
Skip threads which are not running.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Nov 22, 2024
Skip threads which are not running. (cherry picked from commit 0cb2017) Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
added a commit
that referenced
this issue
Nov 22, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this issue
Dec 8, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this issue
Dec 8, 2024
sobolevn
added a commit
that referenced
this issue
Jan 8, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this issue
Jan 12, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this issue
Jan 12, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this issue
Jan 12, 2025
…_workers` (python#126855) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this issue
Jan 12, 2025
…hecking `libregrtest` (python#127033)
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this issue
Jan 12, 2025
Skip threads which are not running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature or enhancement
Proposal:
The code in
Lib/test/libregrtest
already has a smattering of type hints in it, but doesn't currently pass type checking. @vstinner, the primary maintainer of libregrtest, expressed interest to me in seeing whether we could run mypy on libregrtest in CI.This issue is for tracking progress towards that.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Linked PRs
libregrtest
in CI #112558--strict-optional
check on most files #112586--strict-optional
check on most files (#112586) #112602--strict-optional
check on most files (GH-112586) (GH-112602) #112603.py
-file changes from #112558 (#112558) #112605.py
-file changes from GH-112558 (GH-112605) #112607libregrtest
#126352libregrtest
(GH-126352) #126388libregrtest
(GH-126352) #126389strict_optional
forlibregrtest/main.py
#126394strict_optional
forlibregrtest/main.py
(GH-126394) #126802strict_optional = true
forlibregrtest/run_workers
#126855strict_optional = true
forlibregrtest/run_workers
(GH-126855) #126967disallow_any_generics
setting when checkinglibregrtest
#127033disallow_any_generics
setting when checkinglibregrtest
(GH-127033) #127034The text was updated successfully, but these errors were encountered: