Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 695 is not tested to be pickleable #105433

Closed
sobolevn opened this issue Jun 7, 2023 · 2 comments
Closed

PEP 695 is not tested to be pickleable #105433

sobolevn opened this issue Jun 7, 2023 · 2 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2023 •
edited by bedevere-bot
Loading

(or at least I cannot find these tests)

I think that testing the pickle result of functions, classes, and type aliases created with the new syntax is very important.

I propose to add these tests, PR is in the works.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-typing labels Jun 7, 2023
@sobolevn sobolevn self-assigned this Jun 7, 2023
@sunmy2019
Copy link
Member

Sounds reasonable.

@AlexWaygood AlexWaygood changed the title PEP 695 is not tested to pickleable PEP 695 is not tested to be pickleable Jun 7, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 7, 2023
@sobolevn
pythongh-105433: Add pickle tests for PEP695
15b0172
sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 7, 2023
@sobolevn
pythongh-105433: Add pickle tests for PEP695
9e99313
@bedevere-bot bedevere-bot mentioned this issue Jun 7, 2023
Merged
JelleZijlstra pushed a commit that referenced this issue Jun 16, 2023
@sobolevn
gh-105433: Add pickle tests for PEP695 (#105443)
1af8251
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 16, 2023
@sobolevn @miss-islington
pythongh-105433: Add pickle tests for PEP695 (pythonGH-105443)
6d82bd9 
(cherry picked from commit 1af8251)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot mentioned this issue Jun 16, 2023
Merged
@JelleZijlstra
Copy link
Member

Thanks Nikita!

JelleZijlstra pushed a commit that referenced this issue Jun 16, 2023
@miss-islington @sobolevn
[3.12] gh-105433: Add pickle tests for PEP695 (GH-105443) (#105845)
0cb670f 
(cherry picked from commit 1af8251)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
carljm added a commit to carljm/cpython that referenced this issue Jun 16, 2023
@carljm
Merge branch 'main' into modulelocals
b096651 
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Jun 18, 2023
@sobolevn @gvanrossum
pythongh-105433: Add pickle tests for PEP695 (python#105443)
9a75ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JelleZijlstra @sobolevn @sunmy2019