Skip to content

Commit

Permalink
gh-109840: Fix multiprocessing test_waitfor_timeout() (#110428)
Browse files Browse the repository at this point in the history
Don't measure the CI performance: don't fail if cond.wait_for() takes
longer than 1 second on a slow CI.
  • Loading branch information
vstinner committed Oct 5, 2023
1 parent 0db2f14 commit 5eae8dc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Lib/test/_test_multiprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1651,12 +1651,12 @@ def test_waitfor(self):
def _test_waitfor_timeout_f(cls, cond, state, success, sem):
sem.release()
with cond:
expected = 0.1
expected = 0.100
dt = time.monotonic()
result = cond.wait_for(lambda : state.value==4, timeout=expected)
dt = time.monotonic() - dt
# borrow logic in assertTimeout() from test/lock_tests.py
if not result and expected * 0.6 < dt < expected * 10.0:
if not result and expected * 0.6 <= dt:
success.value = True

@unittest.skipUnless(HAS_SHAREDCTYPES, 'needs sharedctypes')
Expand All @@ -1675,7 +1675,7 @@ def test_waitfor_timeout(self):

# Only increment 3 times, so state == 4 is never reached.
for i in range(3):
time.sleep(0.01)
time.sleep(0.010)
with cond:
state.value += 1
cond.notify()
Expand Down

0 comments on commit 5eae8dc

Please sign in to comment.