Skip to content

Commit

Permalink
Followup to issue #14157: respect the relative ordering of values pro…
Browse files Browse the repository at this point in the history
…duced by time.strptime().

Patch by Hynek.
  • Loading branch information
pitrou committed May 14, 2012
1 parent 2d82d04 commit 072e4a3
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Lib/_strptime.py
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,10 @@ def _strptime(data_string, format="%a %b %d %H:%M:%S %Y"):
else:
tz = value
break
leap_year_fix = False
if year is None and month == 2 and day == 29:
year = 1904 # 1904 is first leap year of 20th century
leap_year_fix = True
elif year is None:
year = 1900
# If we know the week of the year and what day of that week, we can figure
Expand Down Expand Up @@ -476,6 +478,12 @@ def _strptime(data_string, format="%a %b %d %H:%M:%S %Y"):
else:
gmtoff = None

if leap_year_fix:
# the caller didn't supply a year but asked for Feb 29th. We couldn't
# use the default of 1900 for computations. We set it back to ensure
# that February 29th is smaller than March 1st.
year = 1900

return (year, month, day,
hour, minute, second,
weekday, julian, tz, gmtoff, tzname), fraction
Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_strptime.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,11 @@ def test_escaping(self):
def test_feb29_on_leap_year_without_year(self):
time.strptime("Feb 29", "%b %d")

def test_mar1_comes_after_feb29_even_when_omitting_the_year(self):
self.assertLess(
time.strptime("Feb 29", "%b %d"),
time.strptime("Mar 1", "%b %d"))

class Strptime12AMPMTests(unittest.TestCase):
"""Test a _strptime regression in '%I %p' at 12 noon (12 PM)"""

Expand Down

0 comments on commit 072e4a3

Please sign in to comment.