Increase UnixNoGilBuild timeout #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example: on build 1985, test_math failed with a timeout (20 min) The next build is a success, but test_math was the slowest test: test_math bad performance is a known issue, unrelated to Free Threading: python/cpython#110327 |
|
cc @itamaro |
itamaro
approved these changes
Apr 11, 2024
| @@ -169,6 +169,9 @@ class UnixNoGilBuild(UnixBuild): | |||
| buildersuffix = ".nogil" | |||
| configureFlags = ["--with-pydebug", "--disable-gil"] | |||
| factory_tags = ["nogil"] | |||
| # 2024-04-11: Free-threading can still be slower than regular build in some | |||
| # code paths, so tolerate longer timeout. | |||
| test_timeout = int(TEST_TIMEOUT * 1.5) | |||
|
|
|||
|
|
|||
| class UnixNoGilRefleakBuild(UnixBuild): | |||
There was a problem hiding this comment.
Should we increase the timeout for this one too?
There was a problem hiding this comment.
UnixNoGilRefleakBuild already uses TEST_TIMEOUT * 10 and I didn't see any test failing with this timeout. I prefer to not make it bigger (until a test fails with timeout), the timeout is already larger than 3 hours! (worker timeout: 3 hour 25 min)
|
Merged, thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.