Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete codecov.yml #409

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Delete codecov.yml #409

merged 1 commit into from
Mar 25, 2022

Conversation

sobolevn
Copy link
Member

I want to discuss whether or not we need it.

First of all, looks like it is ignored by codecov-action: https://github.com/codecov/codecov-action/blob/b049ab51f46ef6cd9c7ca52a856631a818969c7c/src/buildExec.ts#L19-L156

Other users report it as well: codecov/codecov-action#554

Secondly, it looks like our action works without it.
Run: sobolevn#2

So, I see two options:

  1. Just delete it
  2. Think of options we need to transfer to GitHub Actions with: arguments

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #409 (209d7e8) into master (bbc8f7e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1298      1298           
=========================================
  Hits          1298      1298           

@Mariatta Mariatta merged commit dba1039 into python:master Mar 25, 2022
@Mariatta
Copy link
Member

Thanks! Let's try it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants