Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no setuptools-markdown #68

Merged
merged 4 commits into from
May 11, 2018

Conversation

ocefpaf
Copy link
Collaborator

@ocefpaf ocefpaf commented Aug 4, 2017

PyPI will soon support markdown files making this dependency unnecessary.
See https://packaging.python.org/specifications/#description-content-type

@s-celles
Copy link
Member

s-celles commented Aug 4, 2017

Great news Markdown support with PyPI was a long awaited feature!

https://bitbucket.org/pypa/pypi/issues/148/support-markdown-for-readmes
pypi/legacy#148
pypi/warehouse#869

but I'm not sure if this feature is live now

moreover I wonder how Description-Content-Type should be set using setuptools
because pypa/setuptools#1075 is not merged for now

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Aug 4, 2017

Yep. It will take a while longer 😒

But the use of setuptools-markdown here makes it quite hard to package this with external package managers. I am currently "patching" the source to remove it to be able to package it.

TL;DR you don't need to merge this now, or ever 😄, but I really hope that soon README.md will be the standard for PyPI.

@s-celles
Copy link
Member

s-celles commented Aug 4, 2017

According pypa/setuptools#1075 and pypa/packaging.python.org#258

we will probably need to add

long_description_content_type='text/markdown; charset=UTF-8; variant=CommonMark',

or

long_description_content_type='text/markdown; charset=UTF-8',

which default to Markdown rendering with variant CommonMark

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Aug 4, 2017

Yep. I can add that if you are interested in the PR.

@s-celles
Copy link
Member

s-celles commented Aug 4, 2017

Yes. I will merge it when Markdown support in setuptools, twine and Warehouse will be merged.

Just send me a reminder if I forget to merge when the full chain will be ready.

@s-celles
Copy link
Member

What is current status ?

@ocefpaf ocefpaf force-pushed the remove_setuptools-markdown branch from fa43e33 to b720504 Compare May 11, 2018 13:37
@ocefpaf
Copy link
Collaborator Author

ocefpaf commented May 11, 2018

I believe that is done upstream. Here is the oficial example and the issue for the Markdown support.

@s-celles
Copy link
Member

LGTM also

@s-celles s-celles merged commit 089906b into python-windrose:master May 11, 2018
@ocefpaf ocefpaf deleted the remove_setuptools-markdown branch May 11, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants