Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antpath #1016

Merged
merged 9 commits into from
Dec 30, 2018
Merged

Antpath #1016

merged 9 commits into from
Dec 30, 2018

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 8, 2018

Closes #522

@ocefpaf ocefpaf requested a review from Conengmo November 8, 2018 18:09
@ocefpaf ocefpaf added the waiting for review PR is waiting to be reviewed label Nov 8, 2018
@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 15, 2018

@Conengmo this one is rebased and ready for review. Here is an example of it i action:

http://nbviewer.ipython.org/cddef4bcb2972b9a451d2d2ace8e9e4a

@ocefpaf
Copy link
Member Author

ocefpaf commented Dec 11, 2018

@Conengmo this is rebased and ready for another round of reviews.

Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice plugin @ocefpaf! I added some comments. I agree on the need to work on the tests, but let's discuss that separately.

folium/plugins/antpath.py Outdated Show resolved Hide resolved
folium/utilities.py Show resolved Hide resolved
folium/vector_layers.py Show resolved Hide resolved
tests/plugins/test_antpath.py Show resolved Hide resolved
@Conengmo Conengmo added in discussion This PR or issue is being discussed and removed waiting for review PR is waiting to be reviewed labels Dec 23, 2018
Conengmo and others added 2 commits December 24, 2018 16:06
Co-Authored-By: ocefpaf <ocefpaf@gmail.com>
Co-Authored-By: ocefpaf <ocefpaf@gmail.com>
folium/utilities.py Outdated Show resolved Hide resolved
@Conengmo Conengmo merged commit d3765c5 into python-visualization:master Dec 30, 2018
@Conengmo
Copy link
Member

Nice one @ocefpaf! Loving the hypnotizing moving lines on the map.

@Conengmo Conengmo removed the in discussion This PR or issue is being discussed label Dec 30, 2018
@ocefpaf ocefpaf deleted the antpath branch January 3, 2019 21:18
@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 3, 2019

Thanks for the review and merge!

I'll be back from vacations next week and I'm planning a new release.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants