Deprecations for #136 and #284 #309
Conversation
For python-triogh-136 This commit contains: - the actual deprecations - changes to _run.py to prevent warnings - changes to test_run.py to prevent warnings Still need to clean up everything else.
spawn's deprecation is really part of 284, not 136, though I'm handling them both together because they're closely related.
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 99.23% 99.24% +0.01%
==========================================
Files 83 84 +1
Lines 10159 10328 +169
Branches 720 725 +5
==========================================
+ Hits 10081 10250 +169
Misses 61 61
Partials 17 17
Continue to review full report at Codecov.
|
New API: - nursery.child_tasks - nursery.parent_task - task.child_nurseries - task.parent_nursery (may be None) Rationale: python-trio#136 (comment)
- un-document deprecated Task members - update custom supervisor documentation to avoid deprecated APIs
njsmith
force-pushed
the
deprecations-for-136
branch
from
9a2a63b
to
a07218e
Compare
Silly oversight missed in python-triogh-253
njsmith
force-pushed
the
deprecations-for-136
branch
from
088620e
to
b290a96
Compare
|
Should this be mentioned in the first issue? |
|
I'm planning to make a consolidated post to the first issue once I have all these deprecations sorted out. It looks like the actual breakage in 0.2.0 will be very minimal in any case; almost all the changes are easy to put in backcompat shims with warnings. |
|
Sorry, just unearthed this tab again and realized that last sentence was pretty incomprehensible. What I mean is, I realized that almost all the changes are ones where it's easy to do a proper deprecation cycle, so I'm less worried about the disruptiveness of 0.2.0 than I was when I set up issue number 1. (But of course I will still raise a flag there ahead of the release.) |
Deprecates nursery.spawn and most of the nursery and task APIs.
Todo: