Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation framework, and do some deprecations #296

Merged
merged 4 commits into from
Aug 19, 2017

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Aug 19, 2017

trio.socket's sendall method is deprecated in favor of the new
high-level interface (see #291)

trio.run_in_worker_thread is renamed to
trio.run_sync_in_worker_thread (see #68), with the old name retained
for now as a deprecated alias.

By default they're unstyled and don't jump out at all.
Part of the changes for python-triogh-68

Also keeps run_in_worker_thread around as a deprecated alias.
@codecov
Copy link

codecov bot commented Aug 19, 2017

Codecov Report

Merging #296 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
- Coverage   99.18%   99.18%   -0.01%     
==========================================
  Files          79       81       +2     
  Lines        9665    10144     +479     
  Branches      686      731      +45     
==========================================
+ Hits         9586    10061     +475     
- Misses         62       66       +4     
  Partials       17       17
Impacted Files Coverage Δ
trio/_core/_traps.py 100% <ø> (ø) ⬆️
trio/tests/test_ssl.py 100% <ø> (ø) ⬆️
trio/_sync.py 100% <ø> (ø) ⬆️
trio/_deprecate.py 100% <100%> (ø)
trio/__init__.py 100% <100%> (ø) ⬆️
trio/_threads.py 100% <100%> (ø) ⬆️
trio/tests/test_socket.py 100% <100%> (ø) ⬆️
trio/tests/test_threads.py 100% <100%> (ø) ⬆️
trio/_file_io.py 100% <100%> (ø) ⬆️
trio/_socket.py 100% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b49fa...f71aba7. Read the comment docs.

@njsmith
Copy link
Member Author

njsmith commented Aug 19, 2017

The codecov results here don't make any sense at all. The coverage clearly isn't even aligned with the underlying source code ­– there are blank lines marked as "covered", and lines with code marked as "no code here".

And I ran the coverage locally, and I don't see anything unexpected in test_util.py or _highlevel_socket.py. I suspect that some of our CI builders are sending corrupted coverage data, or something like that.

@njsmith njsmith merged commit 1cdb8ea into python-trio:master Aug 19, 2017
@njsmith njsmith deleted the deprecations branch August 19, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant