Remove quasi-public APIs from trio socket interface #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't want this in the "public" socket interface, because it interferes with python-triogh-170.
njsmith
force-pushed
the
fix-SocketType-public-interface
branch
from
a900240
to
e7c9667
Compare
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 99.11% 99.13% +0.01%
==========================================
Files 63 63
Lines 8746 8763 +17
Branches 626 626
==========================================
+ Hits 8669 8687 +18
Misses 61 61
+ Partials 16 15 -1
Continue to review full report at Codecov.
|
This is more prep for python-triogh-170. As of this commit SocketType no longer has any secret-but-quasi-public APIs.
njsmith
force-pushed
the
fix-SocketType-public-interface
branch
from
e7c9667
to
6ee9f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some underscored attributes that were accessed from
SocketStream. Fix that, in preparation for gh-170.