Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark timeout test (~20s) as slow. #188

Closed
wants to merge 1 commit into from

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Jun 7, 2017

Make it skipped by default which highly reduce the runtime of the all test suite, at least locally when "just" running py.test.

Make it skipped by default which highly reduce the runtime of the all
test suite
@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #188 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   98.44%   98.45%   +<.01%     
==========================================
  Files          53       53              
  Lines        6129     6131       +2     
  Branches      476      476              
==========================================
+ Hits         6034     6036       +2     
  Misses         80       80              
  Partials       15       15
Impacted Files Coverage Δ
trio/tests/test_socket.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496493a...0bb5357. Read the comment docs.

@njsmith
Copy link
Member

njsmith commented Jun 7, 2017

Doh, sorry you hit this. This test is actually supposed to run quickly – I run the tests locally all the time, and get grumpy when they take more than ~2.5 seconds total. But I do this on Linux, and it turns out that this test is hitting a MacOS bug :-(. I happened to notice a little while ago while tracking down some other MacOS thing, and fixed it here: 8d40410
but unfortunately I was sloppy and so that fix is caught up in the giant branch of #107

@Carreau
Copy link
Contributor Author

Carreau commented Jun 7, 2017

No worries, I can easily fix that locally. And yes sometime MacOs is a mess. I'm worried about APFS that will roll as a standard and unlike HFS+ stops normalizing unicode filenames.

@njsmith
Copy link
Member

njsmith commented Jun 12, 2017

#107 is merged, so I think this should be fixed. (Please open an issue if not!)

@njsmith njsmith closed this Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants