Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Event.clear() #1093

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jun 10, 2019

Closes: gh-637

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #1093 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
+ Coverage   99.49%   99.54%   +0.04%     
==========================================
  Files         102      102              
  Lines       12392    12398       +6     
  Branches      935      935              
==========================================
+ Hits        12330    12341      +11     
+ Misses         40       36       -4     
+ Partials       22       21       -1
Impacted Files Coverage Δ
trio/_sync.py 100% <100%> (ø) ⬆️
trio/_signals.py 100% <100%> (ø) ⬆️
trio/tests/test_sync.py 100% <100%> (ø) ⬆️
trio/_util.py 100% <0%> (+5.1%) ⬆️

@python-trio python-trio deleted a comment from codecov bot Jun 10, 2019
@njsmith
Copy link
Member Author

njsmith commented Jun 11, 2019

@belm0 is there some way I can convince you to click merge on things instead of just approve :-)

@pquentin pquentin merged commit 497d39e into python-trio:master Jun 11, 2019
@pquentin
Copy link
Member

Thank you!

@njsmith njsmith deleted the deprecate-event-clear branch June 20, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we deprecate trio.Event.clear?
3 participants