Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnLock should be refactored #197

Closed
njsmith opened this issue Jun 11, 2017 · 1 comment
Closed

UnLock should be refactored #197

njsmith opened this issue Jun 11, 2017 · 1 comment
Labels
polish todo soon

Comments

@njsmith
Copy link
Member

njsmith commented Jun 11, 2017

  • The name is too clever by half. Or at least too clever by, say, 5%.

  • It should probably be refactored into a dedicated tool for raising ResourceBusyError, since that's how every caller uses it.
@njsmith njsmith mentioned this issue Jun 11, 2017
Merged
@njsmith
Copy link
Member Author

njsmith commented Aug 17, 2017

Maybe ConflictDetector or ResourceBusyDetector.

@njsmith njsmith mentioned this issue Aug 18, 2017
Closed
njsmith added a commit to njsmith/trio that referenced this issue Aug 19, 2017
@njsmith
Refactor UnLock -> ConflictDetector
675555d 
Just rename it and make it always do ResourceBusyError, since that's
how it's always used.

Fixes python-triogh-197
@njsmith njsmith mentioned this issue Aug 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
polish todo soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njsmith