Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.1 #49

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Release 1.3.1 #49

merged 2 commits into from
Feb 25, 2024

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 25, 2024

No description provided.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (8cdc281) to head (b94149a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files           4        4           
  Lines          86       86           
  Branches       15       15           
=======================================
  Hits           83       83           
  Misses          2        2           
  Partials        1        1           
Files Coverage Δ
sniffio/_version.py 100.00% <100.00%> (ø)

@A5rocks A5rocks merged commit a1cc169 into python-trio:master Feb 25, 2024
22 checks passed
@A5rocks A5rocks deleted the release-1.3.1 branch February 25, 2024 23:24
@addyess
Copy link

addyess commented Feb 27, 2024

with sniffio 1.3.1, i can no longer install into environments with very old setuptools

Processing ./wheelhouse/sniffio-1.3.1.tar.gz
Installing build dependencies: started
Installing build dependencies: finished with status 'error'
error: subprocess-exited-with-error

× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> [3 lines of output]
Looking in links: wheelhouse
ERROR: Could not find a version that satisfies the requirement setuptools>=64 (from versions: 62.1.0)
ERROR: No matching distribution found for setuptools>=64
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 27, 2024

Do you know the oldest setuptools version that supports pep 517 off the top of your head? I can't find anything in the changelog but I saw some reference to fixing that in setup tools 40 at least.

@addyess
Copy link

addyess commented Feb 28, 2024

@A5rocks, not sure. I know my project was trying to use setuptools-62.1.0. I was just reporting in case someone comes along with the same issue. I'll pin to sniffio==1.3.0 in this case

@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 28, 2024

Looks like setuptools==61.0.0 might be the first version that works for us (first version that does pep 621 style things). I'll check and if so, then I can drop the requirement and make a new release.

... On the other hand, I think a very simple solution for you if you wanted to use sniffio==1.3.1 is to use something like build (pip install build) where you do something like python -m build <path to sniffio> -w then pip install <built wheel path> -- build makes an isolated venv and installs requirements into it, meaning no conflicts for building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants