Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes intermittent test_invite_scenarios failure #32

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fixes intermittent test_invite_scenarios failure #32

merged 1 commit into from
Oct 3, 2019

Conversation

jcugat
Copy link
Contributor

@jcugat jcugat commented Oct 2, 2019

Fixes #22

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          11       11           
  Lines         486      486           
  Branches       29       29           
=======================================
  Hits          465      465           
  Misses         17       17           
  Partials        4        4
Impacted Files Coverage Δ
tests/test_app.py 100% <ø> (ø) ⬆️

@webknjaz webknjaz requested a review from njsmith October 2, 2019 21:46
@njsmith njsmith merged commit 64c092b into python-trio:master Oct 3, 2019
@trio-bot
Copy link

trio-bot bot commented Oct 3, 2019

Hey @jcugat, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@njsmith
Copy link
Member

njsmith commented Oct 3, 2019

@jcugat Thanks! Are you interested in contributing more? Can we help you figure out how? lmk :-)

@jcugat jcugat deleted the fix_test_invite_scenarios branch October 3, 2019 18:40
@jcugat
Copy link
Contributor Author

jcugat commented Oct 3, 2019

Initially my plan was to contribute to the trio repo (big fan of all the new concepts like nurseries, cancellation scopes, ... unfortunately I haven't had a chance to try it in a real project yet), but I didn't find any easy first issue to pick up. One of the issues that popped up in this github search was this one, so I thought why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent test failure: timeout from tasks in test_app.test_invite_scenarios
2 participants