This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Asyncify TestPoolManager tests #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 98.81% 98.78% -0.04%
==========================================
Files 22 22
Lines 3204 3204
==========================================
- Hits 3166 3165 -1
- Misses 38 39 +1
|
|
I'd like to understand the coverage drop before merging this. |
We want to avoid sniffing the backend as long as we're testing both trio and anyio-trio.
pquentin
force-pushed
the
asyncify-poolmanager-tests
branch
from
96bebcc
to
d2ad284
Compare
|
Unfortunately codecov won't let me see the coverage change (all diffs are empty), but #227 is certainly part of the problem |
Actually, I'm not sure that I want to understand it. :) I've been meaning to do it for two months, but I lack the motivation. @sethmlarson @njsmith Do you mind if I merge it as is, and look at the coverage issue "later"? |
|
@pquentin Let's merge, coverage can always be fixed later. Onwards to victory! :) |
sethmlarson
approved these changes
Jul 24, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on #225, and shows that the migration is easy!