chore: refactor code quality issues

[akshgpt7]

Description

Hey 👋, I'm a Developer Outreach at DeepSource and ran DeepSource analysis on my fork of the repo. It found some interesting code quality improvements to consider.

This PR fixes a few of the issues detected for you to assess if it is right for you.
Happy to provide the tweaks separately otherwise :)

Summary of changes

• Use literal syntax instead of function calls to create data structures.
• Refactor unnecessary use of comprehension.
• Remove redundant None default.
• Remove assert statement from non-test files.
• Remove unused imports.
• Add .deepsource.toml file for continuous analysis on bug risks/performance/code-quality issues on new changes.

[Bibo-Joshi]

Hey, thanks for the PR. Always appreciated.

Regarding DeepSource: We currently use Codacy for code quality analysis and IIRC we could even find more issues with that, if we'd tighten the settings. Why should we choose to switch to DeepSource rather than sticking with Codacy or switching to other services like e.g. DeepCode.ai? And I mean apart from you getting paid by them? 😜

PS: Tests fail b/c I revoked some bot tokens yesterday that are used in the tests, will update them soonish

[ghost]

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

[Bibo-Joshi]

I just merged #2451 to master, which fixes the failing tests, so please merge from master.

[akshgpt7]

Why should we choose to switch to DeepSource rather than sticking with Codacy or switching to other services like e.g. DeepCode.ai?

@Bibo-Joshi There are various added benefits that DeepSource offers:

• Automatic code formatting to comply with the code style (through Transformers).
• Option to Autofix detected issues through one click.
• DeepSource Python analyzer detects 520 issues as of now (new support being continuously added).
• Less than 5% false positive reports in DeepSource.
• Option to report false positives directly.

These are of course some of the benefits, and just for you to assess if the tool is right for the project :)
If you have any questions, feel free to reach out or have a look at the docs.

[Bibo-Joshi]

Thanks for the info! We'll have to discuss it in the dev team, but I'd like to merge your PR first. Would you mind removing the deepsource config file?

[akshgpt7]

No problem, I've removed the config file @Bibo-Joshi.
If you want, I can open an issue for the same, but it's fine if you want to discuss it internally too :)

[Bibo-Joshi]

Thanks for the contribution @akshgpt7 ! We'll discuss switching in the dev team - your example config file is already a great starting point :)