Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflow: Add python-3.8 #1614

Merged
merged 6 commits into from
Mar 9, 2020
Merged

github workflow: Add python-3.8 #1614

merged 6 commits into from
Mar 9, 2020

Conversation

tsnoam
Copy link
Member

@tsnoam tsnoam commented Nov 15, 2019

No description provided.

@tsnoam
Copy link
Member Author

tsnoam commented Nov 15, 2019

  • workflow fails on py3.8 linux. need to investigate
  • workflow hangs on py3.8 windows. need to investigate as well.

@vergeev
Copy link

vergeev commented Dec 25, 2019

I also wanted to note that it fails on macOS Catalina with an error that basically reads

from telegram import Update
ImportError: cannot import name 'Update' from 'telegram' (unknown location)

Only with python 3.8.

@Bibo-Joshi
Copy link
Member

GH Actions now provides py3.8 (actions/setup-python#30), but test_updater hangs on windows. Will need to investigate

@Bibo-Joshi
Copy link
Member

GH Actions now provides py3.8 (actions/setup-python#30), but test_updater hangs on windows. Will need to investigate

Apparently urlopen() doesn't return for some reason. I remember having a similar problem in #1791, but the networking backend is beyond me 🙈

Copy link
Member

@Bibo-Joshi @tsnoam can you maybe have a look?

@Bibo-Joshi
Copy link
Member

Found the issue at tornadoweb/tornado#2608 and a workaround here.

As far as I can see, urlopen is only used explicitly in test_updater (and in the vendored urllib3 …), so I guess we don't have to make changes elsewhere.

Copy link
Member Author

tsnoam commented Mar 9, 2020

@Bibo-Joshi Good catch!!!

This is a problem related to the webhook Updater.
It's the only component using Tornado.

The workaround is good and should probably be applied in webhookhandler.py

We should also consider moving all imports of tornado to the init of the webhook instead of top of the file.

Copy link
Member

@tsnoam @tsnoam Added the workaround to WebhookHandler, but left the imports at the top of the file, since WebhookServer and WebhookAppClass in the same file use them, too.

@Bibo-Joshi
Copy link
Member

CI fails:

  • py3.7 is unrelated (set_game_score)
  • codecov: Don't know how to get the coverage up …

@tsnoam tsnoam merged commit 13a641b into master Mar 9, 2020
@tsnoam tsnoam deleted the workflow_py38 branch March 9, 2020 21:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants