publishing from Windows breaks with default arguments

[FirefoxMetzger]

The problem

https://github.com/relekang/python-semantic-release/blob/f010a15dd03f4ef34e4093cc1a7ee357c6db12eb/semantic_release/dist.py#L31-L34

The above line works fine on Linux-based systems but breaks on Windows when using the default shell (PowerShell), because -rf is incorrect syntax. The default setting is to remove the dist folder after building, which currently breaks semantic-release publish unless deleting is explicitly disabled.

Expected behavior

Deletion of the folder works as expected regardless of operating system.

A fix that should work on any OS could look something like this

import shutil

def remove_dists(path: str):
    logger.debug(f"Removing build folder: `{path}`")
    shutil.rmtree(path)

[FirefoxMetzger]

PS: If a maintainer is happy to review, I can make a PR with the suggested fix :)

[danth]

I would be happy to merge a PR for this.

[lalish99]

Hi, just to note, that this broke my action.

I had the following implementation:

name: Deploy Main
on:
  push:
    branches:
      - main

jobs:

  release:
    runs-on: ubuntu-latest
    concurrency: release
    outputs:
      tag: ${{ steps.release.outputs.tag }}

    steps:
    - uses: actions/checkout@v2
      with:
        fetch-depth: 0

    - name: Python Semantic Release
      uses: relekang/python-semantic-release@master
      with:
        github_token: ${{ secrets.GH_TOKEN }}

    - name: Expose Release
      id: expose-release
      run: echo "::set-output name=tag::$RELEASE_VERSION"

And it stopped working with the following output on the action:

Building distributions
debug: Removing build folder: `dist`
error: [Errno 2] No such file or directory: 'dist'

After changing the version I use from @masterto @v7.19.2it started working properly again.

I beilive this issue, and #393 caused the error. Given that the release v7.19.2 does not include the solution mentioned here (#393).

[danth]

I think adding ignore_errors=True in the arguments to shutil.rmtree will fix this.