remove SimpleRepositoryPage

[dimbleby]

so far as I can see the only achievement of the SimpleRepositoryPage is to add an unwanted trailing slash, making it impossible to use files rather than directories as single page sources eg https://download.pytorch.org/whl/torch_stable.html

the addition of a trailing slash was made back in pre-history at 1900633. I can't tell what the intention was: but for what it's worth the two testcases in that commit survive today and still pass.

fixes #6885

[abn]

For completeness, the trailing slash comes from PEP 503. The intention with the separation was to allow non compliant repos like this one. Seems somewhere along the lines that support went away causing the single page repos to fail after 1.2.

All URLs which respond with an HTML5 page MUST end with a / and the repository SHOULD redirect the URLs without a / to add a / to the end.

The html page was indeed originally intended to abstract away both cases.

[abn]

See #5517

[dimbleby]

https://storage.googleapis.com/jax-releases/jax_releases.html has absolute links to wheels, so the bogus trailing slash made no difference in the example that #5517 tested against.

single-page repositories with relative links have never worked.

[abn]

#5517 makes use of SinglePageRepository not SimpleRepositoryPage. Guess relative page handing for SinglePageRepository is actually what is broken f the torch repos do not actually work.

Fwiw, I am not saying SimpleRepositoryPage as it stands is worth keeping around, but merely stating that it was separated out from HTMLPage as a PEP 503 simple repo is different to a "single page" repo.

[abn]

the addition of a trailing slash was made back in pre-history at 1900633. I can't tell what the intention was: but for what it's worth the two testcases in that commit survive today and still pass.

For this one, I am fairly certain this was added to avoid redirects, which I think we handle much better these days implicitly.

[dimbleby]

Guess relative page handing for SinglePageRepository is actually what is broken f the torch repos do not actually work

the SinglePageRepository gets a SimpleRepositoryPage:

poetry/src/poetry/repositories/single_page_repository.py

Line 15 in 9cda043

def _get_page(self, name: NormalizedName) -> SimpleRepositoryPage:

It really is the handling of the SimpleRepositoryPage that breaks eg the torch repo

[dimbleby]

I added a testcase to show that this fixes something (and protect against regressions)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.