Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce HashManager to work around FIPS #9101

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Introduce HashManager to work around FIPS #9101

merged 2 commits into from
Mar 3, 2024

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Mar 3, 2024

Resolves: #8310

@Secrus Secrus mentioned this pull request Mar 3, 2024
Closed
2 tasks
@Secrus Secrus force-pushed the fips-mode branch 2 times, most recently from 12d6849 to b1a1ba7 Compare March 3, 2024 00:29
@Secrus Secrus requested a review from a team March 3, 2024 00:41
radoering
radoering requested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put HashManager in a separate module and name the test module after it (for example hash_manager.py and test_hash_manager.py)? IMO, that makes it easier to find relevant unit tests.

@Secrus
Copy link
Member Author

Secrus commented Mar 3, 2024

Can we put HashManager in a separate module and name the test module after it (for example hash_manager.py and test_hash_manager.py)? IMO, that makes it easier to find relevant unit tests.

Done. I forgot to change the test suite name from the old, initial implementation.

@Secrus Secrus requested a review from radoering March 3, 2024 16:06
@abn abn enabled auto-merge (squash) March 3, 2024 18:37
@abn abn merged commit 2478f54 into python-poetry:main Mar 3, 2024
20 checks passed
@Secrus Secrus deleted the fips-mode branch March 3, 2024 19:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radoering radoering radoering approved these changes

@eamanu eamanu eamanu approved these changes

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support FIPS during poetry publish
4 participants
@Secrus @abn @eamanu @radoering