Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add pytorch example for explicit source #9006

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

abn
Copy link
Member

@abn abn commented Feb 24, 2024

Closes: #8246

This is a rework of #8246.

@abn abn added the impact/docs Contains or requires documentation changes label Feb 24, 2024
@abn abn requested a review from a team February 24, 2024 00:34
Copy link

github-actions bot commented Feb 24, 2024

Deploy preview for website ready!

✅ Preview
https://website-cvbwhxikq-python-poetry.vercel.app

Built with commit 8b16de3.
This pull request is being automatically deployed with vercel-action

@abn abn marked this pull request as ready for review February 24, 2024 00:38
@radoering
Copy link
Member

I think the original issue was that there is no hint about explicit sources in https://python-poetry.org/docs/cli/#add so we should at least add a sentence and a link to https://python-poetry.org/docs/repositories/#explicit-package-sources. Otherwise LGTM.

Secrus
Secrus previously approved these changes Feb 24, 2024
@Secrus Secrus enabled auto-merge (squash) February 25, 2024 03:18
@abn abn disabled auto-merge February 25, 2024 03:23
@abn abn merged commit e1159b0 into python-poetry:master Feb 25, 2024
18 checks passed
@abn abn deleted the docs-add-source branch February 25, 2024 03:23
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants