Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 2 installation script by using UTF-8 to decode in get-poetry.py #6830

Closed
wants to merge 1 commit into from

Conversation

chrisburr
Copy link

Pull Request Check List

Resolves: #5989

I know Python 2.7 is no longer supported but I think the fix is sufficiently trivial that it might be worth considering regardless?

@finswimmer
Copy link
Member

finswimmer commented Oct 18, 2022

Hey @chrisburr,

thanks a lot for your contribution 👍 We really appreciate it 🙏

However, we will not merge your suggestion for several reasons:

  • The get-poetry.py script is deprecated for more than one year.
  • This installer cannot be used to install the current stable version of Poetry.
  • Only the outdated and no longer supported 1.1 version can be installed with it.
  • Any Poetry version >=1.0.8 can be installed with the recommended installer.
  • We will remove this installer script soon from the repository Removal of get-poetry.py #6377

Making changes to this script might send the false signal to other users, as they might think it is under active development.

If you still need this installer for any reasons, it is recommended to store a local copy of it.

Best regards,
fin swimmer

@finswimmer finswimmer closed this Oct 18, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing poetry using python2.7 in docker image
2 participants