Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect sys.argv[0] path when calling project scripts #6737

Merged
merged 24 commits into from
Jan 23, 2023
Merged

Fix incorrect sys.argv[0] path when calling project scripts #6737

merged 24 commits into from
Jan 23, 2023

Commits on Nov 13, 2022

  1. fix: RunCommand calling scripts with incorrect executable path 

    Fixes python-poetryGH-965

Calling `sys.argv` should run the same program as the currently
running program. To make calling Poetry scripts through RunCommand
match this behavior, we must set `sys.argv[0]` to be the full path of
the executable.

This change makes the behavior of calling a script through `poetry run`
the same as calling a script directly from the .venv/bin.
    @chdsbd @wagnerluis1982
    chdsbd authored and wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    7273f41 View commit details
    Browse the repository at this point in the history

  2. Python 2 compatibility

    @chdsbd @wagnerluis1982
    chdsbd authored and wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    9173580 View commit details
    Browse the repository at this point in the history

  3. Add basic test 

    There are probably cleaner ways to test the CLI, so let me know.
    @chdsbd @wagnerluis1982
    chdsbd authored and wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    6209264 View commit details
    Browse the repository at this point in the history

  4. doc

    @chdsbd @wagnerluis1982
    chdsbd authored and wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    399ed6d View commit details
    Browse the repository at this point in the history

  5. Rewrite test to run project script

    @wagnerluis1982
    wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    1a915a9 View commit details
    Browse the repository at this point in the history

  6. simplify code

    @wagnerluis1982
    wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    121e42f View commit details
    Browse the repository at this point in the history

  7. fix type on RunCommand.run_script

    @wagnerluis1982
    wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    85174c7 View commit details
    Browse the repository at this point in the history

  8. fix test for windows platform

    @wagnerluis1982
    wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    ee4a2a7 View commit details
    Browse the repository at this point in the history

  9. replace comments for a nice docstring

    @wagnerluis1982
    wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    fd4cee7 View commit details
    Browse the repository at this point in the history

  10. rename Env.{_bin => get_bin_path}

    @wagnerluis1982
    wagnerluis1982 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    c925e39 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Merge remote-tracking branch 'origin/master' into fix-incorrect-execu… 

    …table-path
    @wagnerluis1982
    wagnerluis1982 committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    7ae7d32 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. rename test method

    @wagnerluis1982
    wagnerluis1982 committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4c919b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-incorrect-executable-path

    @wagnerluis1982
    wagnerluis1982 authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    81232c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. improve test readability

    @wagnerluis1982
    wagnerluis1982 committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    c761cfe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-incorrect-executable-path

    @wagnerluis1982
    wagnerluis1982 authored Jan 15, 2023
    Configuration menu
    Copy the full SHA
    e0e01eb View commit details
    Browse the repository at this point in the history

  3. rewrite test assertion 

    In order to avoid argument extraction
    @wagnerluis1982
    wagnerluis1982 committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    c1d579f View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Merge branch 'master' into fix-incorrect-executable-path

    @wagnerluis1982
    wagnerluis1982 authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    74b725e View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Merge branch 'master' into fix-incorrect-executable-path

    @wagnerluis1982
    wagnerluis1982 authored Jan 18, 2023
    Configuration menu
    Copy the full SHA
    0846cd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Merge branch 'master' into fix-incorrect-executable-path

    @wagnerluis1982
    wagnerluis1982 authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    02c9919 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. use script_dirs instead of bin_path, make test more realistic

    @radoering
    radoering committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    e4de1a4 View commit details
    Browse the repository at this point in the history

  2. add script extension ".cmd" when on windows

    @wagnerluis1982
    wagnerluis1982 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    2bdc670 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix-incorrect-executable-path

    @wagnerluis1982
    wagnerluis1982 authored Jan 21, 2023
    Configuration menu
    Copy the full SHA
    713a1de View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. do not change args list

    @wagnerluis1982
    wagnerluis1982 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    a758197 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-incorrect-executable-path

    @wagnerluis1982
    wagnerluis1982 authored Jan 22, 2023
    Configuration menu
    Copy the full SHA
    bf6c3ca View commit details
    Browse the repository at this point in the history