Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] fix(repositories): use urls for versioned JSON API instead of releases #5973

Merged
merged 4 commits into from
Jul 8, 2022
Merged

[1.1] fix(repositories): use urls for versioned JSON API instead of releases #5973

merged 4 commits into from
Jul 8, 2022

Conversation

mkniewallner
Copy link
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code. Not applicable

Backport of #5972 to 1.1 branch.
This also includes 278736c which is required to fix black hook.

@mkniewallner mkniewallner changed the title [1.1] fix(repositories): use urls for versioned JSON API instead of releases [1.1] fix(repositories): use urls for versioned JSON API instead of releases Jul 8, 2022
@mkniewallner mkniewallner marked this pull request as ready for review July 8, 2022 12:33
@mkniewallner mkniewallner requested a review from a team July 8, 2022 12:33
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

If you could prepare a Release PR I can kick it out. (You can get some inspiration from the last release) 🙏

@finswimmer finswimmer merged commit 42a7afb into python-poetry:1.1 Jul 8, 2022
@mkniewallner mkniewallner deleted the fix/fix-releases-key-pypi-repository-1.1 branch July 8, 2022 12:42
@mkniewallner mkniewallner mentioned this pull request Jul 8, 2022
@jakob-keller
Copy link
Contributor

Thanks for addressing this so quickly!

After upgrading to 1.1.14, the issue still occurred on my Mac mini (M1) with CPython 3.9.13.

I had to clear the poetry cache manually to get everything working again:
poetry cache clear --all pypi

Maybe someone else will find themselves in the same situation.

@mkniewallner
Copy link
Member Author

I had to clear the poetry cache manually to get everything working again: poetry cache clear --all pypi

Indeed, we should have mentioned that more clearly, the release was kinda made in a rush to fix the issue ASAP.
Will see if we can change the release notes on the website, and update the changelog, thanks for the suggestion and sharing this for other people.

jsirois added a commit to jsirois/pants that referenced this pull request Jul 9, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 9, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

[ci skip-rust]
[ci skip-build-wheels]
benjyw pushed a commit to pantsbuild/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes #16111

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to pantsbuild/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes #16111

(cherry picked from commit b97936e)
jsirois added a commit to pantsbuild/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes #16111

(cherry picked from commit b97936e)
jsirois added a commit to pantsbuild/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes #16111

(cherry picked from commit b97936e)
@mkniewallner mkniewallner mentioned this pull request Jul 12, 2022
DMRobertson pushed a commit to matrix-org/synapse that referenced this pull request Jul 15, 2022
[1.1.14](https://github.com/python-poetry/poetry/releases/tag/1.1.14)
includes a critical bugfix needed to generate lockfiles when using PyPI
as the source of packages.
(python-poetry/poetry#5973, to accomodate
pypi/warehouse#11775)

[1.1.13](https://github.com/python-poetry/poetry/releases/tag/1.1.13)
includes bugfixes that shouldn't be relevant for us (`poetry self
update` and Windows fixes only).

We shouldn't need to use 1.1.14 in the Docker image as we never `lock`
nor `update`, but I have included it for consistency.

I've also added a quick troubleshooting guide to the dev docs.
glennmatthews referenced this pull request in nautobot/nautobot Aug 11, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants