repo: handle invalid distributions gracefully #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
previously approved these changes
May 19, 2022
neersighted
previously requested changes
May 19, 2022
This change ensures that poetry does not bail out when encountering a bad distributions in `sys_path`. This behaviour is similar to how `pip` handles this today. In addition to ignoring these distributions, we also issue a warning log so users can choose to act on this. Further, this change also handles a scenario where an empty path is present in the `sys_path`.
abn
force-pushed
the
installed-repo-invalid-distribution
branch
from
6206bbc
to
5f68912
Compare
neersighted
approved these changes
May 23, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that poetry does not bail out when encountering a bad distributions in
sys_path. This behaviour is similar to howpiphandles this today. In addition to ignoring these distributions, we also issue a warning log so users can choose to act on this.Further, this change also handles a scenario where an empty path is present in the
sys_path.Additional commits exists in this PR to clean up related tests.
Resolves: #3628
Closes: #4702