Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: list --why as a suboption of --tree in poetry show #5634

Closed
wants to merge 1 commit into from
Closed

Conversation

kosmv
Copy link

@kosmv kosmv commented May 18, 2022

Hi!
Here's my attempt for #5625

@tgolsson
Copy link
Contributor

See my comment on original issue; the docs are unclear but this is even less correct. :-)

@Secrus
Copy link
Member

Secrus commented May 18, 2022

@kosmv thank you for your contribution.

@tgolsson Can you please assist with clearing up how this should work? its cool feature, but in my testing it was hard to find how it should be used. Thank you in advance.

@Secrus Secrus added the area/docs Documentation issues/improvements label May 18, 2022
@github-actions
Copy link

Deploy preview for website ready!

✅ Preview
https://website-2c9gkr47f-python-poetry.vercel.app

Built with commit b8b8a56.
This pull request is being automatically deployed with vercel-action

@kosmv
Copy link
Author

kosmv commented May 18, 2022

@tgolsson Oh right, my bad. I didn't understand why --why can be used alone.

@kosmv kosmv closed this May 18, 2022
@tgolsson
Copy link
Contributor

@Secrus Unless @kosmv wants to finish this I'll make a PR tonight :-)

The intended behavior is as follows:

  • You can use --why when showing table or when showing a tree for a single package.
  • If you use --why for the table it'll include a from a, b, c column
  • If you use --why for a single-package tree it'll root the tree at the parent packages instead of the queried package.

This comment contains the expected two use-cases: #5444 (comment).

The CLI command line is just utterly wrong; I think I had some rebase problems and didn't double-check that well enough. The docs one should probably just specify where it's applicable and not just "when applicable".

@kosmv
Copy link
Author

kosmv commented May 18, 2022

@tgolsson Sorry for not reading your original pull request properly.
My terminal width was reduced, so I couldn't see the from package-name column when I tried your feature.

I won't finish this, you can make your PR :)

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants