Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add install-poetry script workflow #4666

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

abn
Copy link
Member

@abn abn commented Oct 21, 2021

No description provided.

@abn abn force-pushed the ci/install-poetry-script branch from 95ec855 to 386100e Compare October 21, 2021 21:15
@abn abn force-pushed the ci/install-poetry-script branch from 386100e to 785b14a Compare October 21, 2021 21:18
@abn abn marked this pull request as ready for review October 21, 2021 21:26
@abn abn requested a review from a team October 21, 2021 21:26
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the concern I have with this approach is the sheer number of extra checks this adds. What if we only ran the full Matrix on Ubuntu (all Python versions and arguments), and instead just did a basic install test on macOS and Windows?

@abn
Copy link
Member Author

abn commented Nov 10, 2021

I'd prefer to move this into it's own repository, eg: https://github.com/abn/install.python-poetry.org.

The checks are only run if the script file or this action changes. I was hoping that was a decent enough compromise. I am inclined the think that reducing the coverage removes it's usefulness as we tend to have issues with a variety of combinations. Also why I want to move it to it's own repo.

@neersighted
Copy link
Member

Okay, I think that's fair. I guess one of my questions is if the Github UI will be cluttered up by a million skipped checks -- if not, I think we should merge this as a first step and then think about how to go about breaking the install script out into its own repo without breaking existing automation that relies on the current location.

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in light of the filtering based on paths!

@neersighted neersighted merged commit 6c86246 into python-poetry:master Nov 10, 2021
@abn abn deleted the ci/install-poetry-script branch November 10, 2021 16:36
1nF0rmed pushed a commit to 1nF0rmed/poetry that referenced this pull request Nov 15, 2021
edvardm pushed a commit to edvardm/poetry that referenced this pull request Nov 24, 2021
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants