-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add install-poetry script workflow #4666
ci: add install-poetry script workflow #4666
Conversation
95ec855
to
386100e
Compare
386100e
to
785b14a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the concern I have with this approach is the sheer number of extra checks this adds. What if we only ran the full Matrix on Ubuntu (all Python versions and arguments), and instead just did a basic install test on macOS and Windows?
I'd prefer to move this into it's own repository, eg: https://github.com/abn/install.python-poetry.org. The checks are only run if the script file or this action changes. I was hoping that was a decent enough compromise. I am inclined the think that reducing the coverage removes it's usefulness as we tend to have issues with a variety of combinations. Also why I want to move it to it's own repo. |
Okay, I think that's fair. I guess one of my questions is if the Github UI will be cluttered up by a million skipped checks -- if not, I think we should merge this as a first step and then think about how to go about breaking the install script out into its own repo without breaking existing automation that relies on the current location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in light of the filtering based on paths!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.