Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the command for activating venv in Windows #3373

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

m-spitfire
Copy link
Contributor

@m-spitfire m-spitfire commented Nov 17, 2020

  • Fixed the command(deleted the source because you don't need source in
    order to run batch files
  • Made code of the table look better, nothing changed in client.

Pull Request Check List

Resolves: #3372

  • Added tests for changed code. note: I'm just checking this for sake of checkbox, I just contributed to the docs
  • Updated documentation for changed code.

* Fixed the command(deleted the `source` because you don't need `source` in
order to run batch files
* Made code of the table look better, nothing changed in client.
Copy link
Contributor

@thomaszub thomaszub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

@finswimmer finswimmer merged commit 639d5e0 into python-poetry:master Nov 18, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake in activating virtualenv in Windows
3 participants