Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relates-to: #3155 converting duplicated code to fixture #3175

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

sanders41
Copy link
Contributor

Relates-to: #3155

Converting duplicated code to a fixture.

@finswimmer finswimmer requested a review from a team October 11, 2020 06:23
@abn
Copy link
Member

abn commented Oct 12, 2020

@sanders41 thank you for the contribution. Would be great if you can move the other packages (cleo, pendulum) in this file into an autouse fixture. All of these can in in a fixture like this:

@fixture(autouse=true)
def __add_packages(repo):
    ...

@sanders41
Copy link
Contributor Author

@abn I made the update. If I misunderstood what you wanted just let me know and I can update further.

tests/console/commands/debug/test_resolve.py Outdated Show resolved Hide resolved
tests/console/commands/debug/test_resolve.py Outdated Show resolved Hide resolved
@abn abn merged commit d190504 into python-poetry:master Oct 12, 2020
@sanders41 sanders41 deleted the test-cleanup branch October 12, 2020 14:17
@abn abn linked an issue Oct 12, 2020 that may be closed by this pull request
2 tasks
@abn abn removed a link to an issue Oct 23, 2020
2 tasks
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants