Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --trusted-host for non HTTPS repo (#1894) #3014

Merged
merged 10 commits into from
Oct 19, 2020
Merged

Add --trusted-host for non HTTPS repo (#1894) #3014

merged 10 commits into from
Oct 19, 2020

Conversation

estyxx
Copy link
Member

@estyxx estyxx commented Oct 1, 2020

Pull Request Check List

Resolves: #1894

  • Added tests for changed code.
  • Updated documentation for changed code.

This will add --trusted-host {url} to therequirement.txt export at the beginning of the file if the repo is not HTTPS.

@estyxx estyxx changed the title Feature/export trusted host Add --trusted-host for non HTTPS repo, fix #1894 Oct 1, 2020
@estyxx estyxx changed the title Add --trusted-host for non HTTPS repo, fix #1894 Add --trusted-host for non HTTPS repo (#1894) Oct 1, 2020
@estyxx
Copy link
Member Author

estyxx commented Oct 2, 2020

P. S. I saw tests are broken... I wasn't expecting them, think the release effected somehow... I'm looking at them
(I will set it to WIP if was possible)

Apparently, with HTTP legacy repository, I got dependencies that are not in the current repository, so it couldn't find them...

@estyxx estyxx force-pushed the feature/export-trusted-host branch from a770dbc to e38c84b Compare October 4, 2020 17:58
@estyxx estyxx force-pushed the feature/export-trusted-host branch from e38c84b to 4cf3ade Compare October 4, 2020 18:08
@finswimmer finswimmer requested a review from a team October 5, 2020 18:36
@estyxx
Copy link
Member Author

estyxx commented Oct 8, 2020

Fyi this issue is related to Hacktoberfest :)
And for my point of view could be merge tnks :)

abn
abn requested changes Oct 9, 2020
View reviewed changes
poetry/utils/exporter.py Outdated Show resolved Hide resolved
tests/utils/test_exporter.py Show resolved Hide resolved
poetry/utils/exporter.py Outdated Show resolved Hide resolved
@estyxx estyxx requested a review from abn October 13, 2020 10:21
@jaklan
Copy link

jaklan commented Oct 17, 2020

Very useful PR, waiting for that!

@abn abn merged commit 68d6939 into python-poetry:master Oct 19, 2020
@jaklan
Copy link

jaklan commented Nov 5, 2020 •
edited
Loading

@abn I see it was merged to master branch, but not 1.1 - but doesn't it actually classify as a bug fix, so it can be merged there and provided with the next patch release?

@abn
Copy link
Member

abn commented Nov 5, 2020

@jaklan happy accept this ported to 1.1.

Not all bugfixes get backported, and considering this is not a regression we didn't port it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

poetry export: missing --trusted-host argument for non-HTTPS repos
3 participants
@estyxx @jaklan @abn