Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to install only dev dependencies (#2572) #2917

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Add option to install only dev dependencies (#2572) #2917

merged 1 commit into from
Jan 26, 2021

Conversation

opelr
Copy link
Contributor

@opelr opelr commented Sep 14, 2020

Pull Request Check List

Resolves: #2572

  • Added tests for changed code.
  • Updated documentation for changed code.

@opelr opelr force-pushed the issue-2572 branch 2 times, most recently from cd0c1ae to a461281 Compare September 14, 2020 17:49
@opelr opelr changed the title Add option to install only dev dependencies Add option to install only dev dependencies (#2572) Sep 15, 2020
@finswimmer finswimmer requested a review from a team September 15, 2020 18:34
@TylerLubeck
Copy link

Hi! Is there anything I can do to help get this merged? It would be hugely helpful for me

@justinmayer justinmayer mentioned this pull request Jan 26, 2021
Closed
2 tasks
finswimmer
finswimmer requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @opelr. 👍

This one looks good to me. Can you please rebase onto master again, to force the tests to run again?

fin swimmer

finswimmer
finswimmer requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick rebase.

Just one more thing. At the moment the project itself get's installed at the end. I think we should disable this, just like one can do with the --no-root flag.

@opelr @ropelnr
Add option to install only dev dependencies
b1056d7 
Add an option to poetry install to install only dev dependencies,
e.g. poetry install --dev-only.

Fixes python-poetry#2572
@opelr
Copy link
Contributor Author

opelr commented Jan 26, 2021

@finswimmer Sounds good! I updated my commit to reflect your request, let me know if that's what you had in mind.

@opelr opelr requested a review from finswimmer January 26, 2021 20:00
finswimmer
finswimmer approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🚀

@finswimmer finswimmer merged commit d2485b8 into python-poetry:master Jan 26, 2021
@opelr opelr deleted the issue-2572 branch January 26, 2021 20:58
@TylerLubeck
Copy link

Thanks!! y'all are heros

@thedrow thedrow mentioned this pull request Feb 12, 2021
Closed
@hukkin hukkin mentioned this pull request Mar 16, 2021
Closed
1 task
@noamba
Copy link

noamba commented Mar 16, 2021

Hi @opelr @finswimmer, this is a very useful feature for me, many thanks for getting it done.
I don't think this feature is in release 1.1.5, I assume this will be released sometime in the future? Do you have an idea when? Thanks, Noam

@colbyhub
Copy link

@finswimmer it would be very helpful for our team to use this feature! Even if it was just in a preview release, our team could start taking advantage of this. Thank you for your work on this project! 💪

@vchrombie vchrombie mentioned this pull request Apr 28, 2021
Merged
@nniehoff nniehoff mentioned this pull request May 4, 2021
Closed
2 tasks
abn added a commit to abn/poetry that referenced this pull request May 7, 2021
@abn
install: rename --dev-only to --only-dev
66f9dde 
This aligns option to existing options like --no-dev and --no-root.

Relates-to: python-poetry#2917
@abn abn mentioned this pull request May 7, 2021
Closed
abn added a commit to abn/poetry that referenced this pull request May 7, 2021
@abn
install: rename --dev-only to --only-dev
cf1ed57 
This aligns option to existing options like --no-dev and --no-root.

Relates-to: python-poetry#2917
This was referenced Jun 22, 2021
Closed
Closed
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to install only dev dependencies
5 participants
@opelr @TylerLubeck @noamba @colbyhub @finswimmer