Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of markers in old lock files #2482

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

sdispater
Copy link
Member

Pull Request Check List

This PR fixes an issue with #2361.

Basically, we were no longer checking the validity of the markers for the current environment, leading to packages being installed when not necessary.

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added kind/bug Something isn't working as expected area/installer Related to the dependency installer labels Jun 2, 2020
@sdispater sdispater added this to the 1.1 milestone Jun 2, 2020
@sdispater sdispater requested a review from a team June 2, 2020 11:28
@sdispater sdispater force-pushed the fix-handling-of-markers-in-old-files branch from 6d54ce9 to 044047e Compare June 9, 2020 22:26
@sdispater sdispater merged commit b398062 into develop Jun 12, 2020
@sdispater sdispater deleted the fix-handling-of-markers-in-old-files branch June 12, 2020 08:39
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant