Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: unify package inspection logic #2301

Merged
merged 7 commits into from
Apr 25, 2020

Conversation

abn
Copy link
Member

@abn abn commented Apr 13, 2020

This change brings together logic repeated in various places to discover package information. As a side-effect of this various edge cases have been improved and we shouldhave one place to change the code for package inspection related logic.

In addition to the above, this alos cleans up some test code and also unify call of urlparse and download.

Note this requires python-poetry/poetry-core#22. In order for the builds to work, I have created a branch for core that works around a few non issues with the current poetry releases used in ci. Additionally, the FreeBSD tests are failing because of a symbolic link issue (unrelated),

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@abn abn self-assigned this Apr 13, 2020
@abn abn requested a review from sdispater April 13, 2020 14:55
@abn
Copy link
Member Author

abn commented Apr 13, 2020

Builds are failing due to #2302

pyproject.toml Outdated Show resolved Hide resolved
@abn abn marked this pull request as ready for review April 17, 2020 14:39
@abn
Copy link
Member Author

abn commented Apr 17, 2020

@sdispater i have ensured that we only execute python setup.py egg_info for git/path dependencies as it was before.

@abn abn force-pushed the refactor/inspection branch 4 times, most recently from cf78dfd to 692f37b Compare April 19, 2020 17:35
@abn abn requested a review from kasteph April 19, 2020 17:47
@abn abn requested review from a team and kasteph and removed request for sdispater and kasteph April 24, 2020 22:41
poetry/inspection/info.py Outdated Show resolved Hide resolved
This change brings together logic repeated in various places to
discover package information.
abn added 2 commits April 25, 2020 13:33
Moving to tox to use isolated buids to avoid some environment specific
dragons in relation to `poetry install` command. Today, the symlinks
will cause issues when poetry attempts to add an editable install into
the venv due to a pathlib2 bug.
Copy link
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@abn abn merged commit 5466b97 into python-poetry:develop Apr 25, 2020
@abn abn deleted the refactor/inspection branch April 25, 2020 15:20
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants