Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1393 Add system site-packages support in virtualenv (again) #1982

Closed
wants to merge 2 commits into from
Closed

#1393 Add system site-packages support in virtualenv (again) #1982

wants to merge 2 commits into from

Conversation

kam1sh
Copy link
Contributor

@kam1sh kam1sh commented Feb 5, 2020

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.
  • Fixed existing tests (on my machine)
  • Fixed existing tests (in CI)
  • Added logging for changed code

Looks like I really like Poetry, because I'm sumbitting this PR again (previous is #1404). But now I decided to rename setting from virtualenvs.include-system-packages to just virtualenvs.system-packages. I hope it could be merged now at least...

If you think there is a lack in something in this PR, just say and I'll do my best. I have enough spare time to dig in Poetry code base & tests =)

Conan-Kudo
Conan-Kudo previously approved these changes Feb 9, 2020
@finswimmer finswimmer added kind/feature Feature requests/implementations area/venv Related to virtualenv management labels Feb 10, 2020
@four43
Copy link

four43 commented Feb 19, 2020

This will be great for working with conda to install scientific packages, then using poetry to do the rest.

@etijskens
Copy link

etijskens commented Feb 19, 2020 via email

@etijskens
Copy link

many thanks!

@abn abn changed the base branch from develop to master October 16, 2020 12:59
@abn abn dismissed Conan-Kudo’s stale review October 16, 2020 12:59

The base branch was changed.

@abn
Copy link
Member

abn commented Oct 16, 2020

Apoligies for dropping the ball on this one. Feel free to ping on discord if something falls through the crack again. We appricate your contributions, issues reports, PRs and doc fixes alike.

For this particular change, is it possible to get this rebased against master and aligned with what has been merged in #3157 using the virtualenvs.options namespace?

@etijskens
Copy link

can anybody tell me the status of this feature?
I would like to use poetry on a supercomputer, where not using system site packages is an absolute no go. The system site packages are compiled with special care for performances issues.

@sinoroc
Copy link

sinoroc commented Jan 22, 2021

I would like to use poetry on a supercomputer, where not using system site packages is an absolute no go. The system site packages are compiled with special care for performances issues.

A different approach to this:
Why not package those custom-compiled dependencies as wheels and distribute them via a custom index repository?

@vlad0337187
Copy link
Contributor

@abn, fixed this in PR, could you review please ?

@ClementWalter
Copy link

is this released yet? Would really appreciate to use the feature

@vlad0337187
Copy link
Contributor

@ClementWalter , no it wasn't released yet.
But you can install it from GitHub directly:
pipx install git+https://github.com/python-poetry/poetry.git

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/venv Related to virtualenv management kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants