Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using environment variables to configure username and passwords #1961

Closed
wants to merge 1 commit into from
Closed

Conversation

orf
Copy link
Contributor

@orf orf commented Jan 30, 2020

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

As per #1871 you cannot configure HTTP basic auth using environment variables. This is a problem for a lot of use cases:

  1. Docker - using build time secrets means you can inject the HTTP basic auth configuration as an environment and download packages from a private repository without including this information in the resulting container. That's harder to do if you execute poetry config ....

  2. User onboarding - many companies inject credentials into laptops as environment variables, and tools should be configured to work with those with a minimum of configuration. Simply having POETRY_HTTP_BASIC_MY_INTERNAL_PYPI_USERNAME and POETRY_HTTP_BASIC_MY_INTERNAL_PYPI_PASSWORD should be sufficient.

@sdispater
Copy link
Member

Thanks for you contribution.

However, this issue has already been handled in #1909 so I am closing this since it's a duplicate.

@sdispater sdispater closed this Jan 30, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants