-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
>= plus != generates invalid Requires-Dist #5470
Closed
3 tasks done
Labels
kind/bug
Something isn't working as expected
Comments
dargueta
added
kind/bug
Something isn't working as expected
status/triage
This issue needs to be triaged
labels
Apr 20, 2022
abn
added a commit
to abn/poetry-core
that referenced
this issue
May 2, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
abn
added a commit
to abn/poetry-core
that referenced
this issue
May 5, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
abn
added a commit
to abn/poetry-core
that referenced
this issue
May 5, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
abn
added a commit
to abn/poetry-core
that referenced
this issue
May 5, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
abn
added a commit
to abn/poetry-core
that referenced
this issue
May 6, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
abn
added a commit
to abn/poetry-core
that referenced
this issue
May 6, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
abn
added a commit
to abn/poetry-core
that referenced
this issue
May 6, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
radoering
pushed a commit
to python-poetry/poetry-core
that referenced
this issue
May 6, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialised. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this issue
Aug 29, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialised. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
DavidVujic
pushed a commit
to DavidVujic/poetry-core
that referenced
this issue
Aug 31, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialised. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
-vvv
option).Other versions:
pip: 22.0.4
setuptools: 62.1.0
wheel: 0.37.1
Issue
The following requirement:
generates this in the PKG-INFO source distribution:
As you can see from the specification here,
||
is not included in the list of supported operators. When trying to install the package resulting frompoetry build
, pip (correctly) blows up with a syntax error while parsing PKG-INFO:I've also tried it a few other ways, and poetry generated an invalid constraint both times:
^1.8 || ^2.1
became>=1.8,<2.0 || >=2.1,<3.0
>=1.8,<3.0.0,!=2.0.*
became>=1.8,<3.0,<2.0.0 || >=2.1.0
. This is actually wrong because<3.0
should be on the right-hand side.>=1.8,!=2.0.*,<3
became>=1.8,<2.0.0 || >=2.1.0,<3
. Note the 3.0 constraint is now on the correct side.The expected behavior would be:
>=1.8,!=2.0.*
remains the same>=1.8,<3.0.0,!=2.0.*
also is unchanged^1.8 || ^2.1
becomes something like>=1.8,<3.0.0,!=2.0.*
The text was updated successfully, but these errors were encountered: