Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove compatibility code: Python < 3.6 #3860

Closed
abn opened this issue Mar 30, 2021 · 1 comment
Closed

🧹 Remove compatibility code: Python < 3.6 #3860

abn opened this issue Mar 30, 2021 · 1 comment

Comments

@abn
Copy link
Member

abn commented Mar 30, 2021

This is a great issue to work on if you are new to the Poetry code base and want to start contributing. Over the years the poetry code base has added various fixes that catered to now unsupported versions of python. With the release of 1.2, we will drop support for all Python versions prior to 3.6. With this we want to clean up the code base of any such workarounds we did to support backwards compatibility and/or quirks.

We would like to invite first time contributors to work on helping us remove these bits of code that we no longer require. Small changes are welcome.

If you are submitting a pull request associated with this, please keep the pull requests small and modular. This means, do not do too much in one PR and try to do only closely related changes in on PR. Additionally, make sure you add this to your PR description.

Relates-to: #3860

If this is your first contribution here, please refer to #3061 before continuing.

@python-poetry python-poetry locked and limited conversation to collaborators Mar 30, 2021
@abn abn changed the title 🧹 Remove compatibility code: Python < 3.6 🧹 Remove compatibility code: Python < 3.6 Mar 30, 2021
ThatXliner added a commit to ThatXliner/poetry that referenced this issue Mar 30, 2021
ThatXliner added a commit to ThatXliner/poetry that referenced this issue Mar 30, 2021
ThatXliner added a commit to ThatXliner/poetry that referenced this issue Mar 30, 2021
@finswimmer finswimmer reopened this Apr 2, 2021
@abn
Copy link
Member Author

abn commented May 17, 2022

This should now be done thanks largely to the pyugrade plugin.

@abn abn closed this as completed May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants