Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading zeros in version are removed when building wheels #3705

Closed
2 of 3 tasks
rschmied opened this issue Feb 19, 2021 · 3 comments · Fixed by python-poetry/poetry-core#167
Closed
2 of 3 tasks

Leading zeros in version are removed when building wheels #3705

rschmied opened this issue Feb 19, 2021 · 3 comments · Fixed by python-poetry/poetry-core#167
Labels
kind/bug Something isn't working as expected

Comments

@rschmied
Copy link

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: Linux 5.10.15-1024 ClearLinux
  • Poetry version: 1.1.4

Issue

we use the git short commit as part of our version scheme for the wheels (and the rpm package that we ultimately build). however, when the short commit (8 chars) has leading zeros, then Poetry treats that as a number and removes them. Which ultimately leads to a different wheel name than we expect.

To me, this looks like a bug and the version string should not change the output...

$ poetry version 2.2.0.dev0+build.05669607
Bumping version from 2.2.0-dev0 to 2.2.0.dev0+build.05669607
$ poetry build
Building ourpkg (2.2.0.dev0+build.05669607)
 - Building sdist
 - Built ourpkg-2.2.0.dev0+build.5669607.tar.gz
 - Building wheel
 - Built ourpkg-2.2.0.dev0+build.5669607-py3-none-any.whl
$ 
@rschmied rschmied added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Feb 19, 2021
@nschrader
Copy link

nschrader commented Apr 6, 2021

Really a bummer... Makes every 16th commit unusable. Can confirm in 1.1.5.
From what I see inside the generated sdist setup.py is also impacted, but pyproject.toml is not.

@rschmied
Copy link
Author

thanks for fixing! Appreciate it.

@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants