-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solver tries to resolve dependencies not required on platform #2275
Comments
This could be related to issue 1 identified in #2138 (comment). |
I believe this should have the tag Out of curiosity, I'd be interested to have a look at this myself (depending on how messy it may be). But I'm having a bit trouble trying to figure exactly where in poetry/poetry/puzzle/solver.py Line 23 in 288d997
|
@ErikBjare the traceback with The relevant block here could be poetry/poetry/puzzle/solver.py Lines 102 to 103 in 6e053e5
The issue seems to be that poetry is requesting an install operation even if that package is not required. It could also be handled deeper in the |
I've taken a look at it and from my limited understanding of poetry it seems I should check the marker using I also obtained the verbose traceback:
I traced the cause of the SolverProblemError to a SolveFailure being thrown in Right after the Further guidance welcome. |
The dependency from pyuserinput on pypiwin32 is via code in setup.py - https://github.com/PyUserInput/PyUserInput/blob/ac2d4c7a7f4b1a72e70b1a2ef8925d5312fb12bc/setup.py#L19 poetry tries its best to deal with such things, but can't always get it right. The preferred approach is to specify the dependency with pep508 markers. If pyuserinput used markers for its requirements I expect this would all work out fine. |
Closing this as an upstream issue, as explained by @dimbleby. Please contact the maintainer of this package and ask them to fix it. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option).Issue
I'm trying to remove some unneeded dependencies from my project since they are no longer used (pypiwin32 and pyHook).
However, a dependency (PyUserInput) that is still needed on Linux depends on these two old dependencies, but only on Windows.
Since PyUserInput is only a dependency for Linux (selected with
platform = "linux"
) I shouldn't need to install these other two dependencies on Windows anymore, yet the solver complains:PR with changes here: ActivityWatch/aw-watcher-afk#39
Failing CI run here: https://github.com/ActivityWatch/aw-watcher-afk/pull/39/checks?check_run_id=564392363
The text was updated successfully, but these errors were encountered: