-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency management #146
Comments
I really like poetry, but if there are no issues with the current setup I don't really see the point? I did a similar PR in NeuroTechX/EEG-ExPy#22, but it was ultimately not merged (for now). The important thing imo is that @sylvchev and other maintainers are productive in whatever tools are used, which is why we decided against merging my PR in eeg-notebooks, for now. |
Poetry seems like a really nice tool. We could discuss about it during weekly meeting (Thursday 6:30 PM GMT+1, https://meet.jit.si/NeuroTechX-Hacknight) or in this issue. |
@sylvchev I honestly don't know of any real drawbacks (except some bugs I've found: python-poetry/poetry#2275), there are things like:
It works pretty well with pip etc, since it follows standards like PEP 517 and PEP 518 it should be compatible with everything that pip is compatible with. (A good intro: https://grassfedcode.medium.com/pep-517-and-518-in-plain-english-47208ca8b7a6) I'm personally very happy with poetry. I used to hate packaging in Python, but then came pipenv, and then came poetry, and now I'm pretty happy with it. |
Ok, I think this could really help. I think this is really important to promote and facilitate the reproducibility of the results. Poetry, with the automatic handling of package versioning for the different target platform, is a step towards this goal. Also, the fact that we could easily push pypi version is important to simplify the installation process. Let's use poetry for MOABB! |
@ErikBjare I saw you use
poetry
on your ActivityWatch project, and I use it in my projects too.What do you think about incorporating this tool here to have a crossplatform dependencies and easy packaging?
If you and @sylvchev think it's a good idea, I could do a PR for that.
The text was updated successfully, but these errors were encountered: