Skip to content

Commit

Permalink
Correct URL in test_parse_dependency_specification
Browse files Browse the repository at this point in the history
The URL path is used by `mock_download` to determine the path relative
to the fixtures directory to get the download result.

I believe this has been passing on CI because the `copy_or_symlink` call
in `mock_download` happily creates a symlink to a non-existent path, but
when running on Windows without permission to create symlinks,
`shutil.copyfile` is called as a fallback, and fails trying to copy a
non-existent file.
  • Loading branch information
Paul "Hampy" Hampson authored and neersighted committed Jun 8, 2022
1 parent 2afe984 commit 62b24c7
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tests/utils/test_dependency_specification.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@
("../demo", {"name": "demo", "path": "../demo"}),
("../demo/demo.whl", {"name": "demo", "path": "../demo/demo.whl"}),
(
"https://example.com/packages/demo-0.1.0.tar.gz",
{"name": "demo", "url": "https://example.com/packages/demo-0.1.0.tar.gz"},
"https://example.com/distributions/demo-0.1.0.tar.gz",
{
"name": "demo",
"url": "https://example.com/distributions/demo-0.1.0.tar.gz",
},
),
# PEP 508 inputs
(
Expand Down

0 comments on commit 62b24c7

Please sign in to comment.