Update everything #744
Merged
Update everything #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
reviewed
Jul 23, 2024
| @@ -266,17 +266,6 @@ def is_egg(self) -> bool: | |||
| def is_sdist(self) -> bool: | |||
| return self.ext in {".tar.bz2", ".tar.gz", ".zip"} | |||
|
|
|||
| @cached_property | |||
| def is_artifact(self) -> bool: | |||
There was a problem hiding this comment.
SIM103 didn't like the way that it was written: but since the code is unused it is cleaner to remove it altogether than to rearrange it
Secrus
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly motivated by ruff - it is annoying when the ruff that I actually use disagrees with the precommit ruff.
Updated dependencies and vendored dependencies at the same time: because why not?