Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated string defined scripts in favor of reference. Enabled gui scripts. #743

Closed

Conversation

IgnaciodelaTorreArias
Copy link

@IgnaciodelaTorreArias IgnaciodelaTorreArias commented Jul 15, 2024

Resolves:
Deprecating string scripts
python-poetry-core TODO
Continuation to my PR on python-poetry/poetry

  • Added tests for changed code. Updated previous Test
  • Updated documentation for changed code.

As for the deprecation work changes tests toml's to reference scripts, except the ones that shouldn't of course.
Documentation updated on PR

Warning

On tests the deprecation raises a warning on test_builder_convert_entry_points that i don't know how to solve

@radoering
Copy link
Member

I do not think that we have to deprecate anything to support GUI scripts, do we?

@IgnaciodelaTorreArias
Copy link
Author

Well there was a TODO in code (# TODO: deprecate this in favour or reference) so i went ahead, maybe i misunderstood what that meant.
The support for GUI scripts doesn't depend on deprecation, i could separe this into 2 different PR's, if that's the right thing to do?

@radoering
Copy link
Member

Ah, I see. In the light of #708, which deprecates most of tool.poetry.scripts anyway, I do not think it makes sense to address this TODO now. (If I was completely sure that #708 will be included in the next version, I would even say that we do not have to extend tool.poetry.scripts at all.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants