Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement PEP 660 hooks (port from master) #257

Merged
merged 2 commits into from
Feb 26, 2022

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Dec 19, 2021

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@finswimmer finswimmer marked this pull request as ready for review January 27, 2022 18:03
@finswimmer finswimmer requested a review from a team January 27, 2022 18:03
@finswimmer finswimmer force-pushed the ports/pep-660 branch 2 times, most recently from eb1a769 to 35ffcf7 Compare February 10, 2022 21:39
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I compared the changes to the original PR #182)

Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me as well

tests/masonry/test_api.py Show resolved Hide resolved
@finswimmer finswimmer requested a review from abn February 26, 2022 08:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abn abn merged commit 1615275 into python-poetry:1.0 Feb 26, 2022
@finswimmer finswimmer mentioned this pull request Feb 27, 2022
lobziik added a commit to lobziik/schemathesis that referenced this pull request May 9, 2022
Poetry-core implements PEP660 from version 1.0.8.
This patch bumps poetry-core version in build-system section
for enable editabple installation via pip ('pip install -e .').

For more info see:
- python-poetry/poetry#34 (comment)
- python-poetry/poetry#5056
- python-poetry/poetry-core#257
lobziik added a commit to lobziik/schemathesis that referenced this pull request May 9, 2022
Poetry-core implements PEP660 from version 1.0.8.
This patch bumps poetry-core version in build-system section
for enable editabple installation via pip ('pip install -e .').

For more info see:
- python-poetry/poetry#34 (comment)
- python-poetry/poetry#5056
- python-poetry/poetry-core#257
Stranger6667 pushed a commit to schemathesis/schemathesis that referenced this pull request May 9, 2022
Poetry-core implements PEP660 from version 1.0.8.
This patch bumps poetry-core version in build-system section
for enable editabple installation via pip ('pip install -e .').

For more info see:
- python-poetry/poetry#34 (comment)
- python-poetry/poetry#5056
- python-poetry/poetry-core#257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants