Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3285 #124

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Fix #3285 #124

merged 2 commits into from
Jan 29, 2021

Conversation

audunska
Copy link
Contributor

Resolves: python-poetry#3285

  • Added tests for changed code.
  • Updated documentation for changed code.

Fix python-poetry#3285 by removing explicitly included files from the set in poetry.core.masonry.builders.builder.Builder.find_excluded_files. If files are both included and excluded, they are usually excluded because of vcs, so it makes sense to override by explicitly including.

Added a test for this case.

Audun Skaugen added 2 commits January 13, 2021 19:46
Paths for generated code that's excluded by vcs, but then included
explicitly, were wrong because they appared in the exclude list during
Builder.find_excluded_files(). I changed find_excluded_files to not
exclude files which are explicitly included, by taking a set difference.

Added a test for this case.
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants